Skip to content

Plugin base v1 fixes #1410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
euwint merged 13 commits into from
Jan 12, 2026
Merged

Plugin base v1 fixes #1410

euwint merged 13 commits into from
Jan 12, 2026

Conversation

@jstucke
Copy link
Collaborator

@jstucke jstucke commented Sep 19, 2025

  • fixes:
    • removed mixin (which is now part of the base class) from individual plugin class definition
    • fixed test class names
    • added missing __init__.py
    • init() fixes (version should be semver, missing self when referencing metadata class)
    • plugins should not return None as result
    • removed plugin shutdown log spam
  • feat: better handling of failed analyses

@jstucke jstucke requested a review from euwint September 19, 2025 10:17
@jstucke jstucke self-assigned this Sep 19, 2025
@jstucke jstucke force-pushed the plugin-base-v1-fixes branch 2 times, most recently from 66f6792 to 1287915 Compare September 26, 2025 12:43
@codecov-commenter
Copy link

codecov-commenter commented Sep 26, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 77.65363% with 40 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.44%. Comparing base (fd69918) to head (b2289c6).

Files with missing lines Patch % Lines
src/scheduler/analysis/plugin.py 22.72% 17 Missing ⚠️
...c/plugins/analysis/cwe_checker/code/cwe_checker.py 41.66% 7 Missing ⚠️
...ins/analysis/example_plugin/code/example_plugin.py 55.55% 4 Missing ⚠️
...ugins/analysis/input_vectors/code/input_vectors.py 33.33% 4 Missing ⚠️
src/test/unit/analysis/test_plugin_worker.py 94.93% 4 Missing ⚠️
src/plugins/analysis/hashlookup/code/hashlookup.py 60.00% 2 Missing ⚠️
src/scheduler/analysis/scheduler.py 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1410      +/-   ##
==========================================
- Coverage   92.49%   92.44%   -0.06%     
==========================================
  Files         368      370       +2     
  Lines       20678    20802     +124     
==========================================
+ Hits        19126    19230     +104     
- Misses       1552     1572      +20

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jstucke jstucke force-pushed the plugin-base-v1-fixes branch from 1287915 to 7a2c2e1 Compare January 9, 2026 13:54
@jstucke jstucke force-pushed the plugin-base-v1-fixes branch from b140002 to df965f6 Compare January 9, 2026 15:12
@jstucke jstucke force-pushed the plugin-base-v1-fixes branch from d0287f7 to d1c5b5c Compare January 12, 2026 10:13
@euwint euwint merged commit da89d51 into master Jan 12, 2026
9 checks passed
@euwint euwint deleted the plugin-base-v1-fixes branch January 12, 2026 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@euwint euwint euwint approved these changes

Assignees

@jstucke jstucke

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jstucke @codecov-commenter @euwint